Skip to content

Add tests #29

Jump to bottom
Merged
merged 5 commits into from
Sep 17, 2026
Merged

Add tests #29

merged 5 commits into from
Sep 17, 2026
+701 −1

Conversation

emmafre
Copy link
Member

@emmafre emmafre commented Sep 17, 2026 •
edited by minael
Loading

Implemented tests for all components and CharactersPage.tsx. All tests pass

Closes #20

@emmafre emmafre added the test Changes related to tests label Sep 17, 2026
@emmafre emmafre added this to the P1 milestone Sep 17, 2026
@emmafre emmafre requested a review from gurveers September 17, 2026 19:03
@emmafre emmafre self-assigned this Sep 17, 2026
@emmafre emmafre requested a review from a team as a code owner September 17, 2026 19:03
@emmafre emmafre removed the test Changes related to tests label Sep 17, 2026
@emmafre emmafre linked an issue Sep 17, 2026 that may be closed by this pull request
Add tests with Vitest #20
Closed
5 tasks
gurveers
gurveers approved these changes Sep 17, 2026
View reviewed changes
Copy link
Member

@gurveers gurveers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seems to have good coverage and are testing the most important components of the codebase. Great work!

@emmafre emmafre merged commit 7af5b5a into dev Sep 17, 2026
@emmafre emmafre deleted the 20-add-tests branch September 17, 2026 20:14
Sign in to join this conversation on GitHub.
Reviewers

@gurveers gurveers gurveers approved these changes

Assignees

@emmafre emmafre

Labels
None yet
Projects
None yet
Milestone
P1
Development

Successfully merging this pull request may close these issues.

Add tests with Vitest
2 participants
@emmafre @gurveers